On Tue, Sep 22, 2009 at 1:50 PM, Ricardo Cantu <rica...@smartcsc.com> wrote:
> On Tuesday 22 September 2009 10:39:32 am Jeff Trawick wrote: > > On Tue, Sep 22, 2009 at 12:04 PM, Ricardo Cantu <rica...@smartcsc.com > >wrote: > > > I think this patch will do it. See what you think. > > > > Thanks! I think just a couple of tweaks are needed. > > > > Values of -1 for max_requests_per_process need to be fixed at config time > > so that we don't clutter the main logic with migration support. The > > function that handles parsing that directive is > > set_max_requests_per_process() in fcgid_conf.c. > Done. > > > Also in that file, DEFAULT_MAX_REQUESTS_PER_PROCESS needs to be 0 > instead > > of -1. > Done. > > > Then, the check > > + } else if (sconf->max_requests_per_process > 0 // negative > and > > zero are unlimited > > doesn't have to be handled differently than the others. > Done. > > > > > (BTW, it is a tiny bit helpful to omit generated .html.* from patches.) > > > Sorry, will do. > But you omitted the .xml too ;) Anyway, the latest patch and the previous xml have been committed as r817772. Thanks! (I tweaked whitespace ever so slightly and noted that FCGIDMaxRequestsPerProcess/MaxRequestsPerProcess still accepts -1.)
