On Thu, Apr 29, 2010 at 12:06 PM, Greg Ames <[email protected]> wrote:
> > The last time I checked, trunk had a related bug: > https://issues.apache.org/bugzilla/show_bug.cgi?id=43359 . > > . I will look at the patch again and forget mod_status bells and whistles > for now. OK, I reviewed this patch again. It ought to take care of the 2.2.x issue because it delays the complete listener thread termination until all the connections are closed when it's one of the graceful process shutdown scenarios. The logic that sets SERVER_DEAD before we know if the worker thread(s) will be doing useful work again caught my attention. It might be bad because we won't have any clues in the mod_status display about what that worker thread is doing. On the other hand, this process won't be accepting any more new connections, and seeing SERVER_DEAD for these threads would allow perform_idle_server_maintenance() to fork replacement processes sooner. I think I prefer to see SERVER_READY until the worker thread really exits. I don't think we need to worry too much about forking as quickly as possible during a graceful process shutdown. Other opinions? Greg
