mod_lua has 8 separate directives for adding hooks using external files
with Lua code (LuaHookXxxxx) and 8 more for adding the same hooks using
inline Lua code (<LuaHookXxxxx>).  Most of the code to implement these
is common.

I think it'd be easier to understand - and document - the module if we
cut these down to two directives, with an additional argument to
indicate which hook is involved.  E.g. change

LuaHookAccessChecker /path/to/script.lua  funcname
LuaHookAuthChecker   /path/to/script.lua  funcname
LuaHookCheckUserID   /path/to/script.lua  funcname
...

to

LuaHook AccessChecker /path/to/script.lua  funcname
LuaHook AuthChecker   /path/to/script.lua  funcname
LuaHook CheckUserID   /path/to/script.lua  funcname
...


and

<LuaHookAccessChecker funcname>
-- lua code
</LuaHookAccessChecker>

to

<LuaHook AccessChecker funcname>
-- lua code
</LuaHook>


Thoughts?

Dan

Reply via email to