On Sun, Sep 16, 2012 at 08:00:00AM +0200, Kaspar Brand wrote: > I have committed an improved version in r1385214 (in particular, more > tweaking was required to properly handle support/ab, which can't make > use of MOD_CFLAGS etc.). Reviews, further testing and feedback welcome.
Looks good to me, thanks Kaspar. one minor nit/bikeshed-colour-review: - APR_ADDTO(MOD_SSL_LDADD, [-export-symbols-regex ssl_module]) + APR_ADDTO(MOD_LDFLAGS, [-export-symbols-regex ssl_module]) this is currently equivalent but keeping _LDADD seems better. Regards, Joe
