On Jul 30, 2016 10:15 AM, "Yann Ylavic" <[email protected]> wrote: > > On Sat, Jul 30, 2016 at 12:00 AM, <[email protected]> wrote: > > > > Looking for someone with an EBCDIC environment to post the output of > > the test_char.h generated file for verification. > > > [] > > > > +#if APR_CHARSET_EBCDIC > > +/* See util.c for complete explanation of this table */ > > +static const short ucharmap[] = { > > We already have: > #if APR_CHARSET_EBCDIC || defined(isascii) > #define apr_isascii(c) (isascii(((unsigned char)(c)))) > #else > #define apr_isascii(c) (((c) & ~0x7f)==0) > #endif > > so why is this charmap needed?
Eric identified that all other isclass() return their EBCDIC tests, but is isascii() means check 0-127. We aren't asking about that. We are asking if the chr is an equivalent within the ASCII set. > Doesn't APR (via EBCDIC-system libc's isascii) take care of it already? > It seems EBCDIC has never been handled here before, yet APR "ctype" > functions have always been used. What's special with isascii()? We never restricted obs-text correctly.
