Hello Jacob! 2017-07-18 1:25 GMT+02:00 Jacob Champion <[email protected]>:
> On 07/14/2017 02:29 AM, Luca Toscano wrote: > >> http://home.apache.org/~elukey/httpd-2.4.x-mod_proxy_fcgi- >> force_flush-v3.patch created, I tested it quickly and it seems working >> fine (still unsure about using r->connection->pool vs conn->pool in >> palloc). More tests following in the weekend :) >> > Some thoughts: > Thanks a lot for reviewing :) > - This will flush each time a POLLIN event is successfully handled, even > if the event doesn't cause data to be put on the brigade (as is the case > for STDERR or END_REQUEST records, or for the empty end-of-stream record). > This is true, I thought that the "if (rv != APR_SUCCESS)" right before the new code was enough to remove corner cases but I was wrong. Maybe it is only a matter of checking that clen is > 0? Will try to check it today. > - While we're waiting for a POLLIN event in auto-flush mode, we're not > listening to POLLOUT events. Seems like we could/should merge the apr_poll > calls into one. I'm playing around with that now. I didn't do it on purpose because I didn't want to mess with the main apr_poll, but if you find an elegant solution I am all for it. My understanding is that in this case we don't need to listen to POLLOUT events since we are focusing on flushing (giving priority to it), and then we'll pay attention to POLLOUT when the main apr_poll will happen. Luca
