rdblue commented on a change in pull request #14: Pluggable file I/O submodule
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r239299733
##########
File path:
core/src/main/java/com/netflix/iceberg/BaseMetastoreTableOperations.java
##########
@@ -129,24 +132,13 @@ protected void refreshFromMetadataLocation(String
newLocation, int numRetries) {
}
@Override
- public InputFile newInputFile(String path) {
- return fromLocation(path, conf);
+ public String resolveMetadataPath(String fileName) {
+ return newMetadataLocation(baseLocation, fileName);
Review comment:
I think `newMetadataLocation` is a better name than `resolveMetadataPath`
because "resolve" makes me think that there is more work than just tacking on
the right directory. Plus, this is always used for new files. Can you remove
the `static` modifier from `newMetadataLocation` and rename
`resolveMetadataPath`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
