rdblue commented on a change in pull request #14: Pluggable file I/O submodule
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r239300140
##########
File path: core/src/main/java/com/netflix/iceberg/TableOperations.java
##########
@@ -56,27 +55,15 @@
void commit(TableMetadata base, TableMetadata metadata);
/**
- * Create a new {@link InputFile} for a path.
- *
- * @param path a string file path
- * @return an InputFile instance for the path
+ * Obtain a handler to read and write files.
*/
- InputFile newInputFile(String path);
+ FileIO fileIo();
Review comment:
The name `fileIo` seems strange to me because of the clash of capitalization
conventions. IO is normally capitalized, but common Java conventions only
capitalize the first letter in an acronym.
What about naming this something simpler that avoids the problem? I would be
fine with either `files` or `io`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
