rdblue commented on a change in pull request #14: Pluggable file I/O submodule
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r239298837
##########
File path:
core/src/main/java/com/netflix/iceberg/BaseMetastoreTableOperations.java
##########
@@ -98,7 +101,7 @@ protected String writeNewMetadata(TableMetadata metadata,
int version) {
}
String newFilename = newTableMetadataFilename(baseLocation, version);
- OutputFile newMetadataLocation = HadoopOutputFile.fromPath(new
Path(newFilename), conf);
+ OutputFile newMetadataLocation = fileIo.newOutputFile(new
Path(newFilename).toString());
Review comment:
No need for `Path` any more. HadoopFileIO should wrap in `Path`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services