Sure, those classes will be renamed to use Ignite* prefix. Any other comments regarding Configuration or public API changes?
2017-05-16 17:12 GMT+03:00 Alexey Kuznetsov <akuznet...@apache.org>: > Alexey Goncharuk, > > I take a look at source code and noticed classes with names > like: GridCacheDatabaseSharedManager.java > As far as I remember we decided that "Grid" is a kind of "deprecated" > prefix? > > What do you think? Does it make sense to rename? > > On Tue, May 16, 2017 at 9:06 PM, Alexey Goncharuk < > alexey.goncha...@gmail.com> wrote: > > > Denis, > > > > Headers are updated, RAT check is passing now. > > > > 2017-05-16 2:37 GMT+03:00 Denis Magda <dma...@apache.org>: > > > > > The receipt of the software grant (the persistent store) was > acknowledged > > > by Craig Russel. > > > > > > Now, we need to move on with this > > > > > > > In the meanwhile, I’ve prepared the IP Clearance page referring to > the > > > template below but failed to commit the changes to ASF repo: > > > > http://incubator.apache.org/ip-clearance/ip-clearance-template.html > > > > > > > > *Roman S.*, *Cos*, could you help me with this by granting karma or > > > committing the form from under your account? > > > > > > Roman, Cos, could you help with this? > > > > > > *Alex G.*, please add Apache 2.0 copyrights to all source files that > are > > > going to be donated. Presently there is no copyright at all. > > > > > > Everyone interested please spend some time exploring the store's docs > and > > > sources shared in my previous email. If no one has any concerns I will > > > proceed with the donation formalities. > > > > > > — > > > Denis > > > > > > > On May 12, 2017, at 2:59 PM, Denis Magda <dma...@apache.org> wrote: > > > > > > > > Folks, > > > > > > > > The repository with the donation is ready and available for review: > > > > https://github.com/agoncharuk/ignite/tree/pds-donate > > > > > > > > Big and main part of the sources is aggregated in “modules/pds”. The > > > rest, that connects Apache Ignite memory architecture and SQL engine is > > > under “core” and “indexing” modules. Alex Goncharuk should be able to > > point > > > to specific files or commits if required. > > > > > > > > Here is a description: > > > > * Persistent Store Overview: https://cwiki.apache.org/ > > > confluence/display/IGNITE/Persistent+Store+Overview > > > > * Persistent Store Internal Design: https://cwiki.apache.org/ > > > confluence/display/IGNITE/Persistent+Store+Internal+Design > > > > > > > > The SGA will be signed and sent on Monday. > > > > > > > > In the meanwhile, I’ve prepared the IP Clearance page referring to > the > > > template below but failed to commit the changes to ASF repo: > > > > http://incubator.apache.org/ip-clearance/ip-clearance-template.html > > > > > > > > *Roman S.*, *Cos*, could you help me with this by granting karma or > > > committing the form from under your account? > > > > > > > > — > > > > Denis > > > > > > > >> On Apr 25, 2017, at 9:56 AM, Konstantin Boudnik <c...@boudnik.org> > > > wrote: > > > >> > > > >> While no one is suggesting an IP trap laid out in the non-SGA'ed > code > > > >> in this particular case, we don't want to setup a precedent like > this. > > > >> > > > >> From the overall ASF perspective I +1 what Roman has just said. > > > >> > > > >> Thanks, > > > >> -- > > > >> Take care, > > > >> Konstantin (Cos) Boudnik > > > >> > > > >> > > > >> On Wed, Apr 19, 2017 at 11:41 PM, Roman Shaposhnik < > > > ro...@shaposhnik.org> wrote: > > > >>> On Wed, Apr 19, 2017 at 6:21 PM, Dmitriy Setrakyan > > > >>> <dsetrak...@apache.org> wrote: > > > >>>> On Wed, Apr 19, 2017 at 6:00 PM, Konstantin Boudnik < > c...@apache.org > > > > > > wrote: > > > >>>> > > > >>>>> On Tue, Apr 18, 2017 at 11:54PM, Dmitriy Setrakyan wrote: > > > >>>>>> > > > >>>>>> Would a standard SGA suffice here? > > > >>>>>> > > > >>>>>> I believe that ASF guidelines suggest that a discussion should > > > happen > > > >>>>>> first. Once the community gets enough information, we will move > to > > > a PMC > > > >>>>>> vote. I was under the impression that once the PMC vote passes, > > > then the > > > >>>>>> SGA should be provided. Or does GridGain need to provide a > signed > > > SGA > > > >>>>> right > > > >>>>>> away? > > > >>>>> > > > >>>>> That reminds me of that Pelosi's self-inflicted conundrum of "In > > > order > > > >>>>> to see the bill, we should pass the bill" ;) > > > >>>>> > > > >>>> > > > >>>> Haha :) > > > >>>> > > > >>>> SGA != code. In my view, the code should be provided to the > > community > > > for a > > > >>>> review. But I am struggling to see why should an SGA be signed > prior > > > to the > > > >>>> community accepting the donation. > > > >>> > > > >>> There's no such thing as SGA without a reference to a code base. > > > >>> > > > >>> Also, as I explained -- as a community member I would refuse to > look > > > >>> at the code base that doesn't have a proper licensing attached to > it. > > > >>> SGA established this kind of proper licensing. > > > >>> > > > >>> Now, SGA is deinetly not the only way to do so, but it is the > easiest > > > >>> and since you'd have to do it anyway the most convenient for the > > > >>> community. > > > >>> > > > >>> Thanks, > > > >>> Roman. > > > > > > > > > > > > > > > > -- > Alexey Kuznetsov >