Great, sometimes I made it manually in local tests. It will be great to change the situation.
2018-08-01 18:22 GMT+06:00 Stanislav Lukyanov <stanlukya...@gmail.com>: > +1. > > I don’t see why do we need to fallback to multicast for multi-JVM – let’s > just set 127.0.0.1:47500..47509 by default, > it’ll be enough for most (if not all) tests. > > Stan > > From: Dmitriy Pavlov > Sent: 1 августа 2018 г. 14:21 > To: dev@ignite.apache.org > Subject: Re: IP finder in tests > > Hi Denis, > > Thank you for bringing the question here. > > I totally support this change. > > Sincerely, > Dmitriy Pavlov > > ср, 1 авг. 2018 г. в 13:23, Denis Mekhanikov <dmekhani...@gmail.com>: > > > Igniters, > > > > Almost every test in Ignite project has the following pattern: shared > > *TcpDiscoveryVmIpFinder > > *is defined as a field of a test class, which is then used in discovery > > configuration in *getConfiguration(...)* method. There are more than 700 > > test classes with this setup. > > > > But for some reason *TcpDiscoveryMulticastIpFinder *is used in tests by > > default. I don't think, that it should be used in tests at all, since > > external nodes may accidentally affect test results. > > > > The only case, where it makes sense is multi JVM tests. Shared static IP > > finder is not applicable there, since nodes are run in different JVMs and > > cannot share the same IP finder object. > > > > I would like to change the default IP finder to a shared > > *TcpDiscoveryVmIpFinder. > > *In cases, when *GridAbstractTest#isMultiJvm() *returns *true*, we could > > fall back to multicast. > > > > What do you think? > > > > Denis > > > >
