+1 to revert. Some day we should learn this process. Maybe this day is today.
пт, 26 июл. 2019 г. в 10:00, Nikolay Izhikov <nizhi...@apache.org>: > +1 to revert. > > В Пт, 26/07/2019 в 09:48 +0300, Павлухин Иван пишет: > > Alexey, > > > > Actually the commit [1] is very suspicious: > > 1. Commit message "[ML] Hyper-parameter tuning via Genetic Algorithm > > (#6713)" does not refer to a ticket. > > 2. Is there a ticket? Consequently it is not easy to understand what > > was done and check ticket according to regular flow (review, TC run). > > 3. I skimmed through changes and found several code style violations > quite soon. > > > > Should we revert the commit [1] and apply the changes according to our > > conventions [2]? > > > > [1] > https://github.com/apache/ignite/commit/63fbcbf849640edf140047a5111a58f480c95294 > > [2] https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute > > > > чт, 25 июл. 2019 г. в 21:26, <dpavlov.ta...@gmail.com>: > > > > > > Hi Igniters, > > > > > > I've detected some new issue on TeamCity to be handled. You are more > than welcomed to help. > > > > > > If your changes can lead to this failure(s): We're grateful that you > were a volunteer to make the contribution to this project, but things > change and you may no longer be able to finalize your contribution. > > > Could you respond to this email and indicate if you wish to continue > and fix test failures or step down and some committer may revert you commit. > > > > > > * New Trusted Suite failure in master [Check Code Style] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_CheckCodeStyle&branch=%3Cdefault%3E&tab=buildTypeStatusDiv > > > Changes may lead to failure were done by > > > - zaleslaw....@gmail.com > https://ci.ignite.apache.org/viewModification.html?modId=888540 > > > > > > - Here's a reminder of what contributors were agreed to do > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute > > > - Should you have any questions please contact > dev@ignite.apache.org > > > > > > Best Regards, > > > Apache Ignite TeamCity Bot > > > https://github.com/apache/ignite-teamcity-bot > > > Notification generated at 21:26:38 25-07-2019 > > > > > > >
