>From my point, we should divide the sandbox and features that use it. The sandbox is fully implemented and has needed tests.
Also, I added in the main features of Ignite (cache and compute) the sandbox calls. I don't see any problem to have the sandbox in the master branch and implement covering for existing and new features if needed. пт, 11 окт. 2019 г. в 15:21, Вячеслав Коптилин <[email protected]>: > Hi Denis, > > Yep, I understand the scope of the ticket, but... I think it is not a good > idea to merge partly implemented feature(s) into the master branch. > Especially, at this moment. We are at the stage of preparing a new release > and I doubt that all improvements, tests (unit tests, integration tests, > and performance tests) can be implemented before the release branch is cut > off. > Personally, I would prefer to create an epic/feature branch for these > activities. In that case, we can implement a feature step by step and merge > it into the master branch once all components are covered. > > > But, sure, we should execute any user-defined code in the sandbox on a > remote node. Feel free to create issues. > will do. > > Thanks, > S. > > пт, 11 окт. 2019 г. в 14:52, Denis Garus <[email protected]>: > > > Hello, Slava! > > > > The scope of the issue is limited by the following features: > > > > - StreamReceiver for DataStreamer; > > - EntryProcessor; > > - ComputeJob; > > - filter and transformer for ScanQuery. > > > > But, sure, we should execute any user-defined code in the sandbox on a > > remote node. > > Feel free to create issues. > > > > Thanks for the feedback! > > > > пт, 11 окт. 2019 г. в 13:26, Вячеслав Коптилин <[email protected] > >: > > > > > Hello Denis, Anton, > > > > > > Could you please clarify the following aspect? Do we need the same > > > changes/capabilities related to Continuous Queries, Disco listeners, > > > CacheStore Factories etc? > > > > > > Thanks, > > > S. > > > > > > пт, 11 окт. 2019 г. в 12:24, Anton Vinogradov <[email protected]>: > > > > > > > Folks, > > > > > > > > As a prereviewer, I'd like to say that the solution looks good to me, > > but > > > > fresh eyes would be good. > > > > > > > > On Fri, Oct 11, 2019 at 9:40 AM Denis Garus <[email protected]> > > wrote: > > > > > > > > > Hello, Igniters! > > > > > > > > > > I've raised the PR [1] with the sandbox for AI [2]. > > > > > Could somebody review it? > > > > > > > > > > If you have questions and prefer the Slack, I've created the > channel > > > [3]. > > > > > > > > > > 1. https://github.com/apache/ignite/pull/6707 > > > > > 2. https://issues.apache.org/jira/browse/IGNITE-11410 > > > > > 3. https://app.slack.com/client/T4S1WH2J3/CP8JER880 > > > > > > > > > > > > > > >
