Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Fix Base64 Decode error ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3244/1/be/src/util/url-coding-test.cc File be/src/util/url-coding-test.cc: Line 96: TestBase64(string("a\0", 2), "YQA="); can you also test with some data past the '\0', like "a\0b"? http://gerrit.cloudera.org:8080/#/c/3244/1/be/src/util/url-coding.cc File be/src/util/url-coding.cc: Line 154: bool Base64Decode(const string& in, string* out) { Is this function actually used anywhere? Does impala fail to compile or fail any tests if it is just deleted from this file (and url-coding.h, and url-coding-test.cc)? Line 161: *out = string(base64_decode(tmp.begin()), base64_decode(tmp.end())); Maybe just use sasl/saslutil.h's sasl_{en,de}code64? -- To view, visit http://gerrit.cloudera.org:8080/3244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c46023754139ee7eeceeb3b77a3be5d156d608 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
