Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Fix Base64 Decode error ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3244/3/be/src/util/url-coding.cc File be/src/util/url-coding.cc: Line 106: // Base64 encoding turns every 3 bytes into 4 characters. If the length is not This is a near copy of StringFunctions::Base64Encode. Can they be combined into one function? Copying code is not a good choice. Line 151: bool Base64Decode(const string& in, string* out) { If this function is not used anywhere and we have no plan to use it anywhere, it should be removed. -- To view, visit http://gerrit.cloudera.org:8080/3244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c46023754139ee7eeceeb3b77a3be5d156d608 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
