Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Fix Base64 Decode error ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: Line 826: result.CopyFrom(ctx, reinterpret_cast<const uint8_t*>(encoded_str.c_str()), Please avoid this CopyFrom if at all possible. Perhaps make both functions wrappers around a different interface. http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/util/url-coding.cc File be/src/util/url-coding.cc: Line 152: int Base64Decode(const char* in, const int in_len, string* out) { If this is only used in StringFunctions::Base64Decode, it should only exist there, and not here. http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/util/url-coding.h File be/src/util/url-coding.h: Line 47: // Returns 0 for success, 1 for input string too large and 2 for encode fail. Please use a C++11-style enum. -- To view, visit http://gerrit.cloudera.org:8080/3244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c46023754139ee7eeceeb3b77a3be5d156d608 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
