Michael Ho has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3838/2/be/src/runtime/mem-pool.cc File be/src/runtime/mem-pool.cc: PS2, Line 265: if (current_chunk_empty) DCHECK_EQ(chunks_[i].allocated_bytes, 0); Please add a comment stating that !current_chunk_empty doesn't imply the current chunk is not empty. It just means the caller isn't sure it's empty. May be it's better to rename it to 'check_current_chunk_empty' if it's not too verbose. -- To view, visit http://gerrit.cloudera.org:8080/3838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
