Hello Michael Ho, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3838
to look at the new patch set (#5).
Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks
......................................................................
IMPALA-3946: fix MemPool integrity issues with empty chunks
There were various rare code paths that results in the MemPool failing
its own internal integrity checks. This required various small fixes to
ensure that the MemPool was always valid even when there were empty
chunks for various reasons (either from calling Clear() or
ReturnPartialAllocation()).
Testing:
Added unit tests for three secenarios where the integrity check failed.
Also ran fuzz tester to confirm that the original issue was fixed.
Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346
---
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-pool.cc
M be/src/runtime/mem-pool.h
3 files changed, 145 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/3838/5
--
To view, visit http://gerrit.cloudera.org:8080/3838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
