Tim Armstrong has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3838/4/be/src/runtime/mem-pool.cc File be/src/runtime/mem-pool.cc: PS4, Line 106: free chunk > what is a "free chunk"? One with allocated_bytes == 0? not your change, bu Updated the header comments to define it a bit better and clarify the invariants. There were non-trivial changes so it would be good if you could have a quick look. PS4, Line 130: a > big enough ? Done PS4, Line 143: we didn't change any state, > this comment seems to be only interesting due to how the old code worked, b Done PS4, Line 153: We didn't change any state > same. and besides, we did change state but we already un-did it (memtracker Done -- To view, visit http://gerrit.cloudera.org:8080/3838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
