Jim Apple has posted comments on this change.

Change subject: Add .clang-format for Impala's C++ style
......................................................................


Patch Set 1:

> How much churn does this introduce if run over the current
 > codebase?

14% of lines in be/src (excluding thirdparty and gutil) change with this style. 
A number of them are actual inconsistencies. Of the first 10 changes it makes, 
it fixes or "fixes" lines that are:

Inconsistent with comments I have received on my patches: 2

Broken too early: 1

Not following Google's style, which is (nominally) what our style is based on: 7

 > Is it accurate?

I use it for all of my patches. We don't seem to have a completely consistent 
style, but this was built by looking at our code and adjusting it to get fewer 
style comments in my patches.

-- 
To view, visit http://gerrit.cloudera.org:8080/3886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I274c5993c7be344fc4b7729d21a13da993f9f3aa
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-HasComments: No

Reply via email to