Tim Armstrong has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style ......................................................................
Patch Set 2: I ran this on partitioned-aggregation-node.cc and mostly the changes were improvements (i.e. it implemented our coding standards better than we do manually). 90% of the changes were improvements, e.g. wrapping lines in a better way. I ran into some slight oddities: It added an extra space before a comment: - child_batch_->Reset(); // All rows from child_batch_ were processed. + child_batch_->Reset(); // All rows from child_batch_ were processed. It changes the sort order of includes with compound words: -#include "exprs/expr.h" #include "exprs/expr-context.h" +#include "exprs/expr.h" It puts the ternary operator in a different place: - void **codegened_fn_ptr = grouping_expr_ctxs_.empty() ? - reinterpret_cast<void**>(&process_batch_no_grouping_fn_) : - reinterpret_cast<void**>(&process_batch_fn_); + void** codegened_fn_ptr = grouping_expr_ctxs_.empty() + ? reinterpret_cast<void**>(&process_batch_no_grouping_fn_) + : reinterpret_cast<void**>(&process_batch_fn_); I don't think any of the above is a real problem so if there's no way to get Clang to do the original thing (or if we prefer the new thing) then I'm fine with it. -- To view, visit http://gerrit.cloudera.org:8080/3886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I274c5993c7be344fc4b7729d21a13da993f9f3aa Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
