Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks ......................................................................
IMPALA-3946: fix MemPool integrity issues with empty chunks There were various rare code paths that results in the MemPool failing its own internal integrity checks. This required various small fixes to ensure that the MemPool was always valid even when there were empty chunks for various reasons (either from calling Clear() or ReturnPartialAllocation()). Testing: Added unit tests for three secenarios where the integrity check failed. Also ran fuzz tester to confirm that the original issue was fixed. Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346 Reviewed-on: http://gerrit.cloudera.org:8080/3838 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins --- M be/src/runtime/mem-pool-test.cc M be/src/runtime/mem-pool.cc M be/src/runtime/mem-pool.h 3 files changed, 145 insertions(+), 76 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
