Add this info to https://cwiki.apache.org/confluence/display/IMPALA/Using+Gerrit+to+submit+and+review+patches if not already there?
On Thu, Oct 19, 2017 at 10:41 AM, Tim Armstrong <tarmstr...@cloudera.com> wrote: > I thought subsequent drafts were only visible to reviewers (in general > drafts are visible to any reviewers you add to the patch). At least on > older versions of gerrit if you pushed out a draft to a published patchset, > a notification email was sent out but the updated patchset was invisible to > non-reviewers. > > Another feature I find useful for organising related patches is the > "topic". If you push to refs/for/master%topic=buffer-pool then the patch is > associated with a topic. > > On Thu, Oct 19, 2017 at 9:50 AM, Lars Volker <l...@cloudera.com> wrote: > >> Note, that publishing cannot be undone. In particular, after you published >> a change, subsequent pushes to refs/drafts will be public patch sets, too. >> >> On Oct 19, 2017 09:34, "Philip Zeyliger" <phi...@cloudera.com> wrote: >> >> Hey folks, >> >> This wasn't obvious for me, so I figured I'd share it. If you want to >> review your Gerrit changes on the Gerrit UI before sending e-mail to the >> community, you can run something like: >> >> git push asf-gerrit HEAD:refs/drafts/master >> >> This will give you a URL that you can browse to, and you can even run >> https://jenkins.impala.io/view/Utility/job/pre-review-test/ against it. No >> e-mails are sent! >> >> Once you've looked it over, you can hit 'Publish' on the web UI, and, boom, >> e-mails. >> >> Cheers, >> >> -- Philip >>
