I haven't looked at your edits. I was responding to Phil's comment that I quoted.
On Thu, Oct 19, 2017 at 1:08 PM, Jim Apple <jbap...@cloudera.com> wrote: > I'm surprised my edits gave you the impression that I think people should > not review their code before asking for peer review. > > On Thu, Oct 19, 2017 at 1:06 PM, Daniel Hecht <dhe...@cloudera.com> wrote: > >> I think it's a good idea for everyone to review their own code before >> asking for a peer review. A lot of style nits, etc can be addressed >> before the first peer review iteration that way. >> >> On Thu, Oct 19, 2017 at 11:44 AM, Philip Zeyliger <phi...@cloudera.com> >> wrote: >> <snip> >> > I think it's a good idea for new contributors to review their code >> reviews >> > first and explicitly hit publish. Experienced contributors will get >> > sufficiently acquainted with Gerrit over time. >> > >>
