On Thu, Oct 19, 2017 at 10:50 AM, Daniel Hecht <dhe...@cloudera.com> wrote:

> Add this info to
> https://cwiki.apache.org/confluence/display/IMPALA/
> Using+Gerrit+to+submit+and+review+patches
> if not already there?


Thanks for the suggestion.

I updated
https://cwiki.apache.org/confluence/display/IMPALA/Using+Gerrit+to+submit+and+review+patches#UsingGerrittosubmitandreviewpatches-Sendingapatchforreview.1
to basically recommend the draft workflow over the "refs/for" workflow. I
think it's a good idea for new contributors to review their code reviews
first and explicitly hit publish. Experienced contributors will get
sufficiently acquainted with Gerrit over time.

-- Philip

Reply via email to