Ok, just pushed a branch using the staged thrift 0.19.0 generator. https://github.com/apache/iotdb/pull/11183
We need to do more tests on it before the upgrading, such as using the old client with Thrift 0.14.1 to connect the data node with 0.19.0. Using the old data node to connect the config node with new Thrift... Best, Haonan On 2023/09/19 08:02:57 Christofer Dutz wrote: > The repo id of the staged thirft 0.19.0 generator is here: > https://repository.apache.org/content/repositories/orgapacheiotdb-1132 > > So, adding that repository and switching to: > <iotdb-tools-thrift.version>0.19.0.0</iotdb-tools-thrift.version> > > <thrift.version>0.19.0</thrift.version> > > Should do the trick. > > Chris > > Von: Christofer Dutz <christofer.d...@c-ware.de> > Datum: Dienstag, 19. September 2023 um 08:50 > An: dev@iotdb.apache.org <dev@iotdb.apache.org> > Betreff: AW: AW: [DISCUSS] Updating to a newer Thrift version? > I��m currently preparing the build-tools for 0.19.0. > As soon as that��s done, we could simply build iotdb with 0.19.0.0 and simply > try it out? > I couldn��t find any info on the binary protocol being changed in the > release-notes. > But I guess simply trying it out should help. > > Chris > > Von: Xiangdong Huang <saint...@gmail.com> > Datum: Dienstag, 19. September 2023 um 01:50 > An: dev@iotdb.apache.org <dev@iotdb.apache.org> > Betreff: Re: AW: [DISCUSS] Updating to a newer Thrift version? > Hi, > one more concern, is Thrift v0.19 compatible with Thrift v0.14? (It is > better to be compatible for all IoTDB v1.x. ) > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > ���� > �廪��ѧ ����ѧԺ > > > Haonan Hou <hao...@apache.org> ��2023��9��18����һ 18:13д���� > > > It seems that Thrift 0.19.0 is released and supports Java 8 again. ;-) > > https://github.com/apache/thrift/blob/master/CHANGES.md > > > > Best, > > Haonan > > > > On 2023/08/04 10:01:39 Christofer Dutz wrote: > > > Ok �� > > > > > > So, it turns out that the Thrift folks intentionally updated to Java 11 > > but took that back and the next release should be based on Java 8 again. > > > So hopefully that will come soon and then we could have a look about > > compatibility of the generated code. I guess if the wire-protocol didn��t > > change there should generally be no reason for it to not be compatible, and > > if they don��t release a major version, usually this compatibility should > > stay intact (if they sort of follow SemVer) > > > > > > I guess the best path of action would be to do nothing right now �� as an > > alternative, we could of course turn on the Java compilation when building > > thrift and to bundle the jar built by that in the assembly. > > > If we then replace the thrift-lib dependency with a ��system�� scope > > dependency, we could already do that now. But admittedly I would not be in > > favor of doing that. I would recommend for us to wait for the next official > > release. > > > > > > Chris > > > > > > Von: Christofer Dutz <christofer.d...@c-ware.de> > > > Datum: Dienstag, 1. August 2023 um 08:29 > > > An: dev@iotdb.apache.org <dev@iotdb.apache.org> > > > Betreff: Re: [DISCUSS] Updating to a newer Thrift version? > > > I opened a ticket in their jira. Might even prepare a pr... Shouldn't be > > too difficult. > > > > > > Chris > > > > > > Gesendet von Outlook f��r Android<https://aka.ms/AAb9ysg> > > > ________________________________ > > > From: ̷���� <1025599...@qq.com.INVALID> > > > Sent: Monday, July 31, 2023 1:57:28 PM > > > To: dev@iotdb.apache.org <dev@iotdb.apache.org> > > > Subject: Re: [DISCUSS] Updating to a newer Thrift version? > > > > > > Hi, Chris > > > > > > In the latest version of thrift, there are some improvements we'd like > > to make, For example, https://issues.apache.org/jira/browse/THRIFT-5502 > > will down-cycled "connection reset" warn logs. > > > > > > +1 for upgrading thrift. > > > > > > > > > Thanks > > > �D�D�D�D�D�D�D�D�D�D�D�D > > > Xinyu Tan > > > > > > > 2023��7��31�� 19:50��Christofer Dutz <christofer.d...@c-ware.de> д���� > > > > > > > > Hi all, > > > > > > > > While working on the cleanup of the build, I noticed we��re working > > with Thrift in version 0.14.1 however the latest version is 0.18.1 > > > > > > > > Is there a reason we��re sticking to a two-year older version than the > > newest? > > > > > > > > If not: with the pom-cleanup refactoring it should be a thing of > > minutes to update this. > > > > > > > > Chris > > > > > > > > > >
