SizeException will be raised when the BackupIOHandler will have a size of
more than the size parameter. I am not sure yet if I will keep it. What do
you think?

Sure for your other points.

Nicolas

On 7/19/06, Jukka Zitting (JIRA) <[EMAIL PROTECTED]> wrote:

    [
http://issues.apache.org/jira/browse/JCR-442?page=comments#action_12422233]

Jukka Zitting commented on JCR-442:
-----------------------------------

Committed patch-backup-060719.txt in revision 423575.

Some issues to consider:

* The SizeException and RepositoryConfigBackup classes do not have the
correct license headers. Please add them.
* What is the SizeException used for?
* You still have tabs in the code. Check your Java / Code Style /
Formatter settings. I'm using the "Java" settings that has the Tab Policy of
"Spaces only".
* Consider renaming ManagerBackup (that backs up the manager) to
BackupManager (that manages the backup). See the naming discussions we had
earlier.
* Could you come up with a simple test case that sets up a dummy
repository and launches the backup tool on it? For now it doesn't need to
actually do anything useful, just to check that the code runs in addition to
it compiling.

Other than that, keep up the good work! It's nice to see things forming
up.

> Implement a backup tool
> -----------------------
>
>                 Key: JCR-442
>                 URL: http://issues.apache.org/jira/browse/JCR-442
>             Project: Jackrabbit
>          Issue Type: New Feature
>            Reporter: Jukka Zitting
>         Attachments: jackrabbit-1.patch.txt, patch,
patch-backup-060716.txt, patch-backup-060719.txt,
patch-jackrabbit-060716.txt, patch-jackrabbit-060718.txt, patch.txt,
patch.txt, patch.txt, patch.txt
>
>
> Issue for tracking the progress of the Google Summer of Code project
assigned to Nicolas Toper.  The original project requirements are:
> "Implement a tool for backing up and restoring content in an Apache
Jackrabbit content repository. In addition to the basic content hierarchies,
the tool should be able to efficiently manage binary content, node version
histories, custom node types, and namespace mappings. Incremental or
selective backups would be a nice addition, but not strictly necessary."

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira





--
a+
Nico
my blog! http://www.deviant-abstraction.net !!

Reply via email to