Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-148155899
Okay, @afs, I've squashed everything into two commits. They are basically
orthogonal, although there is a tiny leak from the first into the second (in
`DatasetGraphWithRecord`), because I found a clearer way of typing mutations
later in the summer. The first is the dataset-with-operation-record that I did
earlier, that provides a real abort function to any wrapped MRSW dataset. The
second is the persistent-data-structure-based MR+SW dataset impl. Let me know
if you would prefer these to be broken out into two separate PRs-- that's no
problem, I just didn't want to fire multiple PRs at once without clearing it. I
can easily remedy the small leak and build two PRs.
You are right in that other than that, there aren't really natural
boundaries inside each commit. That's a little unfortunate, because I know it
will make review more of a pain in the neck, but at least I can promise that of
the extant code into which this is being flung, nothing is touched outside of
adding dependencies to POM files. This is all new stuff and shouldn't bother
anything else.
Now back to ISWC!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
