[ 
https://issues.apache.org/jira/browse/JENA-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085802#comment-15085802
 ] 

ASF GitHub Bot commented on JENA-1083:
--------------------------------------

Github user ajs6f commented on the pull request:

    https://github.com/apache/jena/pull/120#issuecomment-169384106
  
    Third time is the charm!
    
    I think this time I have a good factoring that begins to separate the 
notion of ordering from the kind of data structure which stores the nodes. This 
will be useful for JENA-1084, which I am also working on. I wish this could 
look a little cleaner, but I cannot separate the state for ordering and the 
state for node storage in the nicest way because of single-inheritance, or at 
least I can't see how to do that. (Suggestions welcome!)


> MInor refactoring in TupleTables
> --------------------------------
>
>                 Key: JENA-1083
>                 URL: https://issues.apache.org/jira/browse/JENA-1083
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: ARQ
>            Reporter: A. Soroka
>            Priority: Minor
>
> There are some minor refactorings available for TupleTable and its subtypes, 
> particularly PMapTripleTable and PMapQuadTable that will clarify their use. 
> Specifically, current impls of those abstract types have to override several 
> methods for adding, removing, and finding tuples. In fact, the only 
> information being added when those methods are overridden is conversion 
> between canonical and internal tuple ordering. This refactoring is to provide 
> methods that do that conversion and nothing else, which will make two methods 
> the most that any implementation of those abstract classes will have to 
> provide.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to