[
https://issues.apache.org/jira/browse/JENA-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089002#comment-15089002
]
ASF GitHub Bot commented on JENA-1083:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/120#discussion_r49173865
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/tuple/TupleMap.java ---
@@ -46,7 +46,6 @@
* {@code 0<-1, 1<-2, 2<-0}
* and the "putTransform" is where to place the items: {@code 0->2, 1->0,
2->1}.
*/
-final
public class TupleMap {
/*
--- End diff --
Changes to `TupleMap` aren't needed.
See comments about QuadTupleMap.
> MInor refactoring in TupleTables
> --------------------------------
>
> Key: JENA-1083
> URL: https://issues.apache.org/jira/browse/JENA-1083
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Reporter: A. Soroka
> Priority: Minor
>
> There are some minor refactorings available for TupleTable and its subtypes,
> particularly PMapTripleTable and PMapQuadTable that will clarify their use.
> Specifically, current impls of those abstract types have to override several
> methods for adding, removing, and finding tuples. In fact, the only
> information being added when those methods are overridden is conversion
> between canonical and internal tuple ordering. This refactoring is to provide
> methods that do that conversion and nothing else, which will make two methods
> the most that any implementation of those abstract classes will have to
> provide.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
