[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440946#comment-16440946
 ] 

ASF GitHub Bot commented on JENA-1524:
--------------------------------------

Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/401#discussion_r182097398
  
    --- Diff: jena-arq/src/main/java/org/apache/jena/system/JenaInit.java ---
    @@ -0,0 +1,40 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.jena.system;
    +
    +import org.apache.jena.sys.JenaSystem;
    +
    +/**
    + * This is a temporary adapter for implementations to transition to 
[JENA-1524]
    + */
    +public class JenaInit {
    --- End diff --
    
    I'd prefer this to be called "JenaSystem" then init() is 
    
    ```
      @Deprecated
      public static void init() {
             org.apache.jena.sys.JenaSystem.init();
       }
    ```
    
    because this will work with existing code.  If that's OK, I will do that as 
part of the merge.


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> -------------------------------------------------------------------------------
>
>                 Key: JENA-1524
>                 URL: https://issues.apache.org/jira/browse/JENA-1524
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Jena
>    Affects Versions: Jena 3.7.0
>            Reporter: Christopher Johnson
>            Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to