[
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448648#comment-16448648
]
ASF GitHub Bot commented on JENA-1524:
--------------------------------------
Github user afs commented on the issue:
https://github.com/apache/jena/pull/401
I've tried out the PR and it passes the build and Fuseki starts up. I
renamed the ServiceLoader files as `org.apache.jena.sys.JenaSubsystemLifecycle`
(I have a script for that now,I can do that after the PR is merged).
One other change is class `system.JenaInit` => `...system.jenaSystem` for
compatibility.
This is the JDI version, not the "speculative thought" above. That works,
but does risk changing initialization order between jena-arq and jena-core
which is the most sensitive part of initialization. That does not cause
problems in the test suite but deployed applications are a big unknown. Given
the risks and impacts, I'm currently inclined to go straight to the change to
`META-INF/services/org.apache.jena.sys.JenaSubsystemLifecycle`.
Putting in an adapter `org.apache.jena.system.JenaSubsystemLifecycle` ends
up as replicating the machinery to find services.
It's a bit bumpy for people working from development - we can let them know
via dev@ that they need to do a clearup and rebuild.
So - looking good!
> org.apache.jena.system is split by org.apache.jena.arq and
> org.apache.jena.core
> -------------------------------------------------------------------------------
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
> Issue Type: Bug
> Components: Jena
> Affects Versions: Jena 3.7.0
> Reporter: Christopher Johnson
> Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and
> org.apache.jena.core since org.apache.jena.system can be read from both.
> This cannot be resolved with --patch-module since arq and core provide
> different implementations. Suggestion is to make a distinction by renaming
> system to sys in either one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)