[
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441067#comment-16441067
]
ASF GitHub Bot commented on JENA-1524:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/401#discussion_r182128407
--- Diff:
apache-jena-osgi/jena-osgi/src/main/resources/META-INF/services/org.apache.jena.system.JenaSubsystemLifecycle
---
@@ -1,4 +1,4 @@
-org.apache.jena.system.InitJenaCore
+org.apache.jena.sys.InitJenaCore
--- End diff --
I hope this debt isn't too bad because it can be signalled via deprecation.
As ever, there is a balance.
The services filename ATM is
`org.apache.jena.system.JenaSubsystemLifecycle`. I'm happy to and have a
interface `...system.JenaSubsystemLifecycle` to make the transition not too
abrupt.
(
Speculative thought, maybe trying too hard:
Can we actually move initialization all to jena-arq and just leave
`Serializer` behind? `InitARQ` would call to be non-lifecycle managed
initialization code in jena-core. That fixes the jena-core/jena-arq
relationship. This may be less debt in the sense that it is a relationship the
code depends on anyway.
People using only jena-core aren't impacted - we actively discourage that
but it happens. jena-core initialization happens via services currently but it
can be dropped as it is using "services" to call itself, so that flexibility is
unnecessary and it can just call itself in a fixed fashion.
)
> org.apache.jena.system is split by org.apache.jena.arq and
> org.apache.jena.core
> -------------------------------------------------------------------------------
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
> Issue Type: Bug
> Components: Jena
> Affects Versions: Jena 3.7.0
> Reporter: Christopher Johnson
> Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and
> org.apache.jena.core since org.apache.jena.system can be read from both.
> This cannot be resolved with --patch-module since arq and core provide
> different implementations. Suggestion is to make a distinction by renaming
> system to sys in either one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
