Also the actual file names covered by the licenses need to be mentioned. Note that the binary LICENSE section includes the full jar name, including the .jar. The source section needs to do likewise.
There may need to be some updates to the unit test to deal with the source licenses. On 19 April 2016 at 11:02, sebb <seb...@gmail.com> wrote: > These are *source* files so the licenses belong under license/src. > > Also the final section of the main LICENSE file is intended for > binary-only code. > (It's not all that obvious at present) > > On 19 April 2016 at 07:33, Philippe Mouawad <philippe.moua...@gmail.com> > wrote: >> Hi sebb, >> I filled in in root LICENSE file the license information for the 4 >> components. >> Do we need to also add the MIT license in license/bin folder ? >> Thanks >> >> On Tue, Apr 19, 2016 at 3:24 AM, sebb <seb...@gmail.com> wrote: >> >>> On 19 April 2016 at 01:32, sebb <seb...@gmail.com> wrote: >>> > On 17 April 2016 at 18:03, Milamber <milam...@apache.org> wrote: >>> >> Hello, >>> >> >>> >> The second release candidate for JMeter 3.0 (r1739623) has been >>> prepared, >>> >> and your votes are solicited. >>> >> >>> >> This release brings a lot of new features (over 100) and fixes many bugs >>> >> (60). >>> >> >>> >> If you can, some tests of this release candidate (load tests and/or >>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes are >>> >> welcome. >>> >> >>> >> You can read the New and Noteworthy section with some screenshots to >>> >> illustrate improvements and full list of changes at: >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html >>> >> >>> >> JMeter is a Java desktop application designed to load test functional >>> >> behavior and measure performance. The current version is targeted at >>> Java >>> >> 7+. >>> >> >>> >> Archives/hashes/sigs: >>> >> >>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/ >>> > >>> > FTR, the revision is: r13285 >>> > >>> >> RAT report: >>> >> >>> >> >>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt >>> >> >>> >> MD5 hashes of archives for this vote: >>> >> >>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz >>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip >>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip >>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz >>> >> >>> >> Site Docs are here: >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/ >>> >> >>> >> Maven staging repository is accessible here: >>> >> >>> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/ >>> >> >>> >> Tag: >>> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/ >>> >> >>> >> Keys are here: >>> >> https://www.apache.org/dist/jmeter/KEYS >>> >> >>> >> N.B. >>> >> To download the dependencies: "ant download_jars" >>> >> >>> >> To create the jars and test JMeter: "ant package test". >>> >> >>> >> JMeter 3.0 requires Java 7 or later to run. >>> >> >>> >> Some known issues and incompatible changes are listed on changes page. >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html >>> >> >>> >> >>> >> All feedback and vote are welcome. >>> >> >>> >> [ ] +1 I support this release >>> >> [ ] +0 I am OK with this release >>> >> [ ] -0 OK, but.... >>> >> [X] -1 I do not support this release (please indicate why) >>> >> >>> > >>> > (binding) >>> > >>> > Sorry but there are some files missing from the source archive: >>> > >>> > Only in v3_0_RC2: .gitignore >>> > Only in v3_0_RC2: .svn >>> > Only in v3_0_RC2: .travis.yml >>> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap: >>> > LICENSE >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social: >>> > .gitignore >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive: >>> > .gitignore >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot: >>> > .gitignore >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot: >>> > Makefile >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome: >>> > .gitignore >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs: >>> > .gitattributes >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs: >>> > .gitignore >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs/test: >>> > .gitignore >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/metisMenu: >>> > LICENSE >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/mocha: >>> > LICENSE >>> > Only in >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/morrisjs: >>> > .gitignore >>> > Only in v3_0_RC2: checkstyle-suppressions.xml >>> > Only in v3_0_RC2: doap_JMeter.rdf >>> > Only in v3_0_RC2/lib: api >>> > Only in v3_0_RC2/lib: doc >>> > Only in v3_0_RC2/lib: ext >>> > Only in v3_0_RC2/lib: junit >>> > Only in v3_0_RC2: rat-excludes.txt >>> > Only in v3_0_RC2/test: resources >>> > >>> > The .* files are OK, as is the doap (we ought to move that) >>> > Also the lib subdirectories. >>> > >>> > But the rest ought to be in the source archives, or some should >>> > perhaps be dropped from SVN >>> >>> The LICENSE files are misplaced. >>> >>> The software items need to be mentioned in the main LICENSE file, and >>> stored under the licenses/ folder if necessary. >>> >>> It's important that the user does not have to go looking for LICENSE >>> files; they need to be all included or referenced from the top level >>> file. >>> >>> >>> > Also the source archives don't agree: docs is missing from the zip file >>> > >>> > Maybe we don't actually need to store the docs tree in SVN but if we >>> > do it should be in both the source archives. >>> > >>> >> The vote will remain open for at least 72 hours. >>> >> >>> >> The PMC members please indicate the mention "(binding)" with your vote. >>> >> >>> >> >>> >> Note: If the vote passes, the intention is to release the archive files >>> >> and rename the RC tag as the release tag. >>> >> >>> >> Thanks in advance! >>> >> >>> >> Milamber >>> >> >>> >> >>> >> >>> >> >>> >> >> >> >> -- >> Cordialement. >> Philippe Mouawad.
