----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/#review29341 -----------------------------------------------------------
Could you add a unit test? I am thinking of providing a decoder that always throws an exception and making sure that we can still iterate through all the messages. core/src/main/scala/kafka/consumer/ConsumerIterator.scala <https://reviews.apache.org/r/15805/#comment56525> iter can be of type IteratorTemplate. Then, we don't have to do the cast in remove(). core/src/main/scala/kafka/consumer/ConsumerIterator.scala <https://reviews.apache.org/r/15805/#comment56523> Should we log the partition id too? core/src/main/scala/kafka/consumer/ConsumerIterator.scala <https://reviews.apache.org/r/15805/#comment56524> Can use topic. - Jun Rao On Nov. 22, 2013, 10:37 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15805/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 10:37 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1140 > https://issues.apache.org/jira/browse/KAFKA-1140 > > > Repository: kafka > > > Description > ------- > > KAFKA-1140.v1 > > > Dummy > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerIterator.scala > a4227a49684c7de08e07cb1f3a10d2f76ba28da7 > > Diff: https://reviews.apache.org/r/15805/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
