Yes, we will have to pass in the decoders to MessageAndMetadata. Thanks,
Jun On Tue, Nov 26, 2013 at 10:09 AM, Guozhang Wang <guw...@linkedin.com> wrote: > Does this enforce the key/value decoder to be passed also into > MessageAndMetadata? > > Guozhang > ------------------------------ > *From:* Jun Rao [nore...@reviews.apache.org] on behalf of Jun Rao [ > jun...@gmail.com] > *Sent:* Tuesday, November 26, 2013 9:30 AM > *To:* kafka; Jun Rao; Guozhang Wang > *Subject:* Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's > comments > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15805/ > > Thinking about this a bit more. It seems that a better approach is to move > the decoding into MessageAndMetadata. We define two methods key() and > message() that do the decoding and throw a RuntimeException back to the > caller if decoding fails. This way, the client can still get the metadata > (offset, partitionId, etc) associated with a message even when decoding fails. > > > - Jun Rao > > On November 25th, 2013, 8:55 p.m. UTC, Guozhang Wang wrote: > Review request for kafka. > By Guozhang Wang. > > *Updated Nov. 25, 2013, 8:55 p.m.* > *Bugs: *KAFKA-1140 <https://issues.apache.org/jira/browse/KAFKA-1140> > *Repository: *kafka > Description > > KAFKA-1140.v2 > > > KAFKA-1140.v1 > > > Dummy > > Diffs > > - core/src/main/scala/kafka/consumer/ConsumerIterator.scala > (a4227a49684c7de08e07cb1f3a10d2f76ba28da7) > - core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala > (ef1de8321c713cd9d27ef937216f5b76a5d8c574) > > View Diff <https://reviews.apache.org/r/15805/diff/> >
