> On Nov. 26, 2013, 2:45 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala, lines > > 102-103 > > <https://reviews.apache.org/r/15805/diff/3/?file=390866#file390866line102> > > > > We probably should just use ConsumerConfig.ConsumerTimeoutMs here, to > > make it clear that we don't want to timeout.
> On Nov. 26, 2013, 2:45 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala, lines > > 98-99 > > <https://reviews.apache.org/r/15805/diff/3/?file=390866#file390866line98> > > > > We can just add messageSet to queue directly. In this test, topicInfo > > is irrelevant. > > We still need this for checking consumed offset. > On Nov. 26, 2013, 2:45 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala, lines > > 108-126 > > <https://reviews.apache.org/r/15805/diff/3/?file=390866#file390866line108> > > > > To really test that we can iterate over messages with decoding errors, > > could we have the first half of messages with decoding errors and the > > second half without, and make sure that we get the correct offsets when > > iterating messages in the second half? We can iterate all the messages with decoding errors, but first try to get their offsets and validate they are correct, and only expecting exceptions when calling value() functions. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/#review29412 ----------------------------------------------------------- On Nov. 25, 2013, 8:55 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15805/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2013, 8:55 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1140 > https://issues.apache.org/jira/browse/KAFKA-1140 > > > Repository: kafka > > > Description > ------- > > KAFKA-1140.v2 > > > KAFKA-1140.v1 > > > Dummy > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerIterator.scala > a4227a49684c7de08e07cb1f3a10d2f76ba28da7 > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala > ef1de8321c713cd9d27ef937216f5b76a5d8c574 > > Diff: https://reviews.apache.org/r/15805/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
