[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942389#comment-13942389
]
Guozhang Wang commented on KAFKA-1251:
--------------------------------------
Review comments in the RB (some comments on metrics is on the very first RB
https://reviews.apache.org/r/17263). In general:
1. Performance: in the old producer we still do some metrics recording in the
sender thread, can we verify that have a similar impact as the new code?
2. List of metrics:
"batch-size-avg", "The average number of bytes per partition sent in requests."
=> per batch?
"select-*" => the selector is sort of the implementation detail, shall we
rename to "io-layer-*"
"select-percentage", "io-percentage" => naming not self-descriptive.
"waiting-threads" => "waiting-threads-count"
"ready-partitions" => "ready-partitions-count"
Add "message-size-max": I understand that it can be computed from
"bytes-sent-per-second" / "message-send-rate", but I think this is still good
to illustrate it directly.
> Add metrics to the producer
> ---------------------------
>
> Key: KAFKA-1251
> URL: https://issues.apache.org/jira/browse/KAFKA-1251
> Project: Kafka
> Issue Type: Sub-task
> Components: producer
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Attachments: KAFKA-1251.patch, KAFKA-1251_2014-03-19_10:19:27.patch,
> KAFKA-1251_2014-03-19_10:29:05.patch, KAFKA-1251_2014-03-19_17:30:32.patch
>
>
> Currently there are no metrics.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
