[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948165#comment-13948165
]
Neha Narkhede commented on KAFKA-1251:
--------------------------------------
Thanks for the latest patch, Jay. Overall metrics look great, I saw one problem
while running the producer performance test -
I ran ProducerPerformance on a local broker and saw one problem. A per node
sensor "node--1" gets registered (in addition to the correct one "node-0"),
possibly since the node id somehow gets passed in as -1. See screenshot below -
!metrics.png!
Other review comments I have are minor.
> Add metrics to the producer
> ---------------------------
>
> Key: KAFKA-1251
> URL: https://issues.apache.org/jira/browse/KAFKA-1251
> Project: Kafka
> Issue Type: Sub-task
> Components: producer
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Attachments: KAFKA-1251.patch, KAFKA-1251_2014-03-19_10:19:27.patch,
> KAFKA-1251_2014-03-19_10:29:05.patch, KAFKA-1251_2014-03-19_17:30:32.patch,
> KAFKA-1251_2014-03-25_17:07:39.patch, metrics.png
>
>
> Currently there are no metrics.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
