What do you think Ismael? I agreed initially because I saw the commit message says it fixes a performance regression. But admittedly I don't have much context on this particular issue
If it's low risk then I don't have a strong argument against including it. However I aim to cut the rc tomorrow or Thursday, and if it hasn't been cherrypicked by then I won't block the release on it. On Tue, Feb 9, 2021 at 4:53 PM Luke Chen <show...@gmail.com> wrote: > Hi Ismael, > Yes, I agree it's like an improvement, not a bug. I don't insist on putting > it into 2.6, just want to bring it to your attention. > In my opinion, this issue will block users who adopt the scala 2.13.4 or > later to use Kafka 2.6. > So if we still have time, we can consider to cherry-pick the fix into 2.6 > and 2.7. > > What do you think? > > Thank you. > Luke > > On Wed, Feb 10, 2021 at 3:24 AM Ismael Juma <ism...@juma.me.uk> wrote: > > > Can you elaborate why this needs to be in 2.6? Seems like an improvement > > versus a critical bug fix. > > > > Ismael > > > > On Mon, Feb 8, 2021 at 6:39 PM Luke Chen <show...@gmail.com> wrote: > > > > > Hi Sophie, > > > I found there is 1 issue that should be cherry-picked into 2.6 and 2.7 > > > branches: KAFKA-12312 < > https://issues.apache.org/jira/browse/KAFKA-12312 > > >. > > > Simply put, *Scala* *2.13.4* is released at the end of 2020, and we > > > upgraded to it and fixed some compatible issues on this PR > > > <https://github.com/apache/kafka/pull/9643>, more specifically, it's > > here > > > < > > > > > > https://github.com/apache/kafka/pull/9643/files#diff-fda3fb44e69a19600913bd951431fb0035996c76325b1c1d84d6f34bec281205R292 > > > > > > > . > > > We only merged this fix on *trunk*(which will be on 2.8), but we didn't > > > tell users (or we didn't know there'll be compatible issues) not to > adopt > > > the latest *Scala* *2.13.4*. > > > > > > Therefore, I think we should cherry-pick this fix into 2.6 and 2.7 > > > branches. What do you think? > > > > > > Thank you. > > > Luke > > > > > > > > > > > > > > > > > > On Tue, Feb 9, 2021 at 3:10 AM Sophie Blee-Goldman < > sop...@confluent.io> > > > wrote: > > > > > > > Hey all, > > > > > > > > Since all outstanding bugfixes seem to have made their way over to > the > > > 2.6 > > > > branch by now, I plan to move ahead with cutting an RC. As always, > > please > > > > let me know if you uncover and critical or blocker bugs that affect > 2.6 > > > > > > > > Thanks! > > > > Sophie > > > > > > > > On Thu, Jan 28, 2021 at 9:25 AM John Roesler <vvcep...@apache.org> > > > wrote: > > > > > > > > > Thanks so much for stepping up, Sophie! > > > > > > > > > > I'm +1 > > > > > > > > > > -John > > > > > > > > > > On Wed, 2021-01-27 at 17:59 -0500, Bill Bejeck wrote: > > > > > > Thanks for taking this on Sophie. +1 > > > > > > > > > > > > Bill > > > > > > > > > > > > On Wed, Jan 27, 2021 at 5:59 PM Ismael Juma <ism...@juma.me.uk> > > > wrote: > > > > > > > > > > > > > Thanks Sophie! +1 > > > > > > > > > > > > > > Ismael > > > > > > > > > > > > > > On Wed, Jan 27, 2021 at 2:45 PM Sophie Blee-Goldman < > > > > > sop...@confluent.io> > > > > > > > wrote: > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > I'd like to volunteer as release manager for a 2.6.2 release. > > > This > > > > is > > > > > > > being > > > > > > > > accelerated > > > > > > > > to address a critical regression in Kafka Streams for Windows > > > > users. > > > > > > > > > > > > > > > > You can find the release plan on the wiki: > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+2.6.2 > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Sophie > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
