Hi,

While reviewing the PR (https://github.com/apache/kafka/pull/11220) we
decided to adjust some of the method names of ReplicationPolicy to
better match the actual topic names.

You can see the changes in
https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=165227180&selectedPageVersions=17&selectedPageVersions=16

Let us know if you have any feedback.

Thanks


On Mon, Aug 23, 2021 at 1:05 PM Omnia Ibrahim <o.g.h.ibra...@gmail.com> wrote:
>
> Thanks, everyone for the feedback and votes. I'm closing the vote with:
>
>    - 3 +1 (binding) votes from Mickael, Gwen and David
>
>
>    - 4 +1 (non-binding) votes from Ryanne, Igor, Lopo and Josep
>
>
> On Mon, Aug 23, 2021 at 11:31 AM David Jacot <dja...@confluent.io.invalid>
> wrote:
>
> > +1 (binding). Thanks for the KIP, Omnia.
> >
> > On Mon, Aug 23, 2021 at 11:42 AM Omnia Ibrahim <o.g.h.ibra...@gmail.com>
> > wrote:
> >
> > > Can I get one last +1 binding for this KIP, please?
> > >
> > > On Mon, Aug 16, 2021 at 5:16 PM Omnia Ibrahim <o.g.h.ibra...@gmail.com>
> > > wrote:
> > >
> > > > Thanks Gwen.
> > > > Can I get one more +1 binding for the KIP?
> > > >
> > > > On Mon, Aug 2, 2021 at 2:51 AM Gwen Shapira <g...@confluent.io.invalid
> > >
> > > > wrote:
> > > >
> > > >> +1 (binding). Thank you for your patience and clear explanations,
> > Omnia.
> > > >>
> > > >> On Mon, Jul 26, 2021 at 3:39 PM Omnia Ibrahim <
> > o.g.h.ibra...@gmail.com>
> > > >> wrote:
> > > >>
> > > >> > Bumping up this voting thread.
> > > >> >
> > > >> > On Fri, Jul 16, 2021 at 1:57 PM Omnia Ibrahim <
> > > o.g.h.ibra...@gmail.com>
> > > >> > wrote:
> > > >> >
> > > >> > > Hi,
> > > >> > > Can I get 2 more +1 binding for this KIP?
> > > >> > > Thanks
> > > >> > >
> > > >> > > On Fri, Jul 2, 2021 at 5:14 PM Omnia Ibrahim <
> > > o.g.h.ibra...@gmail.com
> > > >> >
> > > >> > > wrote:
> > > >> > >
> > > >> > >> Hi All,
> > > >> > >>
> > > >> > >> Just thought of bumping this voting thread again to see if we can
> > > >> form a
> > > >> > >> consensus around this.
> > > >> > >>
> > > >> > >> Thanks
> > > >> > >>
> > > >> > >> On Thu, Jun 24, 2021 at 5:55 PM Mickael Maison <
> > > >> > mickael.mai...@gmail.com>
> > > >> > >> wrote:
> > > >> > >>
> > > >> > >>> +1 (binding)
> > > >> > >>> Thanks for the KIP!
> > > >> > >>>
> > > >> > >>> On Tue, May 4, 2021 at 3:23 PM Igor Soarez
> > > <soa...@apple.com.invalid
> > > >> >
> > > >> > >>> wrote:
> > > >> > >>> >
> > > >> > >>> > Another +1 here, also non-binding.
> > > >> > >>> >
> > > >> > >>> > Thank you Omnia!
> > > >> > >>> >
> > > >> > >>> > --
> > > >> > >>> > Igor
> > > >> > >>> >
> > > >> > >>> >
> > > >> > >>> > On Fri, Apr 30, 2021, at 3:15 PM, Ryanne Dolan wrote:
> > > >> > >>> > > +1 (non-binding), thanks!
> > > >> > >>> > >
> > > >> > >>> > > On Thu, Jan 21, 2021, 4:31 AM Omnia Ibrahim <
> > > >> > o.g.h.ibra...@gmail.com>
> > > >> > >>> wrote:
> > > >> > >>> > >
> > > >> > >>> > >> Hi
> > > >> > >>> > >> Can I get a vote on this, please?
> > > >> > >>> > >>
> > > >> > >>> > >> Best
> > > >> > >>> > >> Omnia
> > > >> > >>> > >>
> > > >> > >>> > >> On Tue, Dec 15, 2020 at 12:16 PM Omnia Ibrahim <
> > > >> > >>> o.g.h.ibra...@gmail.com>
> > > >> > >>> > >> wrote:
> > > >> > >>> > >>
> > > >> > >>> > >>> If anyone interested in reading the discussions you can
> > find
> > > >> it
> > > >> > >>> here
> > > >> > >>> > >>>
> > > >> https://www.mail-archive.com/dev@kafka.apache.org/msg113373.html
> > > >> > >>> > >>>
> > > >> > >>> > >>> On Tue, Dec 8, 2020 at 4:01 PM Omnia Ibrahim <
> > > >> > >>> o.g.h.ibra...@gmail.com>
> > > >> > >>> > >>> wrote:
> > > >> > >>> > >>>
> > > >> > >>> > >>>> Hi everyone,
> > > >> > >>> > >>>> I’m proposing a new KIP for MirrorMaker 2 to add the
> > > ability
> > > >> to
> > > >> > >>> control
> > > >> > >>> > >>>> internal topics naming convention. The proposal details
> > are
> > > >> here
> > > >> > >>> > >>>>
> > > >> > >>>
> > > >> >
> > > >>
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-690%3A+Add+additional+configuration+to+control+MirrorMaker+2+internal+topics+naming+convention
> > > >> > >>> > >>>>
> > > >> > >>> > >>>> Please vote in this thread.
> > > >> > >>> > >>>> Thanks
> > > >> > >>> > >>>> Omnia
> > > >> > >>> > >>>>
> > > >> > >>> > >>>
> > > >> > >>> > >
> > > >> > >>>
> > > >> > >>
> > > >> >
> > > >>
> > > >>
> > > >> --
> > > >> Gwen Shapira
> > > >> Engineering Manager | Confluent
> > > >> 650.450.2760 | @gwenshap
> > > >> Follow us: Twitter | blog
> > > >>
> > > >
> > >
> >

Reply via email to