Hi Mason, Thanks for the KIP. But I think since the quota value won't change from time to time unless admin alter it, it might be waste of resources to record it on each produce/fetch API. It can alternatively be achieved by using the kafka-configs.sh to describe ALL users/clients/default to have a overview of the quota values when needed.
What do you think? Thank you. Luke, On Wed, Nov 3, 2021 at 10:53 PM Mickael Maison <mickael.mai...@gmail.com> wrote: > Hi Mason, > > Thanks for the KIP. I think it's a good idea to also emit quota limits > as metrics. It certainly simplifies monitoring/graphing if all the > data come from the same source. > > The KIP looks good overall, just a couple of questions: > - Have you considered enabling the new metrics by default? > - If you prefer keeping a configuration to enable them, what about > renaming it to "client.quota.value.metric.enable" or even > "quota.value.metric.enable"? > > Thanks, > Mickael > > On Wed, Oct 27, 2021 at 11:36 PM Mason Legere > <mason.leg...@salesforce.com.invalid> wrote: > > > > Hi All, > > > > Haven't received any feedback on this yet but as it was a small change > have > > made a PR showing the functional components: pull request > > <https://github.com/apache/kafka/pull/11435> > > Will update the related documentation outlining the new metric attributes > > in a bit. > > > > Best, > > Mason Legere > > > > On Sat, Oct 23, 2021 at 4:00 PM Mason Legere < > mason.leg...@salesforce.com> > > wrote: > > > > > Hi All, > > > > > > I would like to start a discussion for my proposed KIP-786 > > > < > https://cwiki.apache.org/confluence/pages/resumedraft.action?draftId=191335406&draftShareId=9a2f3d65-5633-47c8-994c-f5a14738cb1e&;> > which > > > aims to allow client quota values to be emitted as a standard jmx MBean > > > attribute - if enabled in the static broker configuration. > > > > > > Please note that I originally misnumbered this KIP and am re-creating > this > > > discussion thread for clarity. The original thread can be found at: > Original > > > Email Thread > > > < > https://lists.apache.org/thread.html/r44e154761f22a42e4766f2098d1e33cb54865311f41648ebd9406a4f%40%3Cdev.kafka.apache.org%3E > > > > > > > > Best, > > > Mason Legere > > > >
