Hi Florin, Thanks for the KIP. I am +1 (binding).
There is a small typo in the Proposed Changes section: `parse.header` should be `parse.headers`. Best, David On Mon, Nov 22, 2021 at 6:20 PM Bill Bejeck <bbej...@gmail.com> wrote: > > Hi Florin, > > Thanks for the KIP, this seems like a very useful addition. > > +1(binding). > > -Bill > > On Mon, Nov 22, 2021 at 12:00 PM Florin Akermann <florin.akerm...@gmail.com> > wrote: > > > Hi Luke and Tom > > > > @Tom: Thanks for the vote. > > > > @Luke: Thanks for the feedback. > > > > I have updated the KIP accordingly with regards to your comments on the > > remaining case (false,false) and the motivation. > > > > Regarding the "not only UTF-8": As far as I understand John it is fine to > > limit the scope for this change to UTF-8 only as it is a handy addition on > > its own. Other formats can be relatively easily supported by adding more > > properties in later KIPs. In my reply to John (email from 21 Nov 2021, > > 11:29 UTC) I also added an explanation why I limited the scope to UTF-8 > > only. > > > > Thanks, > > Florin > > > > > > > > On Mon, 22 Nov 2021 at 10:32, Tom Bentley <tbent...@redhat.com> wrote: > > > > > Hi Florin, > > > > > > Thanks for the KIP! > > > > > > +1 (binding), > > > > > > Kind regards, > > > > > > Tom > > > > > > On Mon, Nov 22, 2021 at 6:51 AM Luke Chen <show...@gmail.com> wrote: > > > > > > > Hi Florin, > > > > Thanks for the KIP. > > > > > > > > This KIP makes sense to me. Just a comment that the motivation section > > is > > > > not clearly explain why this KIP is important. > > > > I think John already mentioned a good motivation, which is to support > > > "not > > > > only UTF-8". > > > > You should put that into the KIP, and of course if you have other > > > thoughts, > > > > please also add them into KIP. > > > > > > > > Also, in the "public interface" section, there are 3 "Default parsing > > > > pattern", I think you should add 1 remaining case (false, false) to > > make > > > it > > > > complete. > > > > > > > > Otherwise, look good to me. > > > > > > > > Thank you. > > > > Luke > > > > > > > > > > > > On Sun, Nov 21, 2021 at 7:37 PM Florin Akermann < > > > florin.akerm...@gmail.com > > > > > > > > > wrote: > > > > > > > > > Hi John, > > > > > > > > > > Thanks for the vote and feedback. > > > > > > > > > > The thought occurred to me too. > > > > > > > > > > Do I understand it correctly: the current version of the > > > > > kafka-console-producer cannot be used for anything other than UTF-8 > > > keys > > > > > and values? > > > > > (There is no other implementation of MessageReader other than the > > > > > ConsoleProducer$LineMessageReader) > > > > > In other words, currently users seem to only apply it with utf-8 > > > strings > > > > > for keys and values? > > > > > This is why I figured I would not deviate from this assumption solely > > > for > > > > > the headers. > > > > > > > > > > I will happily raise another KIP / Jira if there is a need to specify > > > > other > > > > > formats / serializers for headers, keys and/or values. > > > > > > > > > > Thanks, > > > > > Florin > > > > > > > > > > > > > > > On Sat, 20 Nov 2021 at 19:34, John Roesler <vvcep...@apache.org> > > > wrote: > > > > > > > > > > > Hi Florin, > > > > > > > > > > > > Thanks for the KIP! > > > > > > > > > > > > I think the assumption that header values are UTF-8 strings might > > not > > > > > hold > > > > > > up in the long run, but it seems like we can easily add a property > > > > later > > > > > to > > > > > > specify the format. It seems like this scope is probably a handy > > > > addition > > > > > > on its own. > > > > > > > > > > > > I’m +1 (binding) > > > > > > > > > > > > Thanks, > > > > > > John > > > > > > > > > > > > > > > > > > On Fri, Nov 19, 2021, at 15:06, flo wrote: > > > > > > > < > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-798%3A+Add+possibility+to+write+kafka+headers+in+Kafka+Console+Producer > > > > > > > > > > > > > > > > > > > > > > > > > > >
