Just to clarify, the re-triggering of Jenkins jobs would be controlled via
the "jenkins: github_whitelist:" YAML section which we already made use of.
I definitely agree that we should leverage this more to make it easy for
collaborators to trigger builds.

Regarding the 20 collaborators limit, the ASF Infra team has indicated that
this is an ASF limit. Perhaps if we make it to 20 active collaborators and
need to add more, we could consult with the Infra team to figure out a
solution. In other words, maybe that's a problem for tomorrow :)

Here's what we have currently in trunk:
https://github.com/apache/kafka/blob/trunk/.asf.yaml#LL24-L28

jenkins:
  github_whitelist:
    - ConcurrencyPractitioner
    - ableegoldman
    - cadonna


-David

On Fri, Apr 28, 2023 at 12:34 PM Philip Nee <philip...@gmail.com> wrote:

> Hi all, opinion from a regular person here: I think being able to
> re-trigger jenkin's test and tagging can be very helpful for a lot of
> times.
>
> On Fri, Apr 28, 2023 at 9:31 AM John Roesler <vvcep...@apache.org> wrote:
>
> > Hi all,
> >
> > This is a great suggestion! It seems like a really good way to make the
> > Apache Kafka project more efficient in general and also smooth the path
> to
> > committership.
> >
> > I've brought the topic up with the Apache Kafka PMC to consider adopting
> a
> > policy around the "collaborator" rule.
> >
> > In the mean time, it would be great to hear from the broader community
> > what your thoughts are around this capability.
> >
> > Thanks,
> > -John
> >
> > On Fri, Apr 28, 2023, at 10:50, Justine Olshan wrote:
> > > I'm also a bit concerned by the 20 active collaborators rule. How do we
> > > pick the 20 people?
> > >
> > > Justine
> > >
> > > On Fri, Apr 28, 2023 at 8:36 AM Matthias J. Sax <mj...@apache.org>
> > wrote:
> > >
> > >> In general I am +1
> > >>
> > >> The only question I have is about
> > >>
> > >> > You may only have 20 active collaborators at any given time per
> > >> repository.
> > >>
> > >> Not sure if this is a concern or not? I would assume not, but wanted
> to
> > >> bring it to everyone's attention.
> > >>
> > >> There is actually also a way to allow people to re-trigger Jenkins
> jobs:
> > >> https://github.com/apache/kafka/pull/13578
> > >>
> > >> Retriggering test is a little bit more sensitive as our resources are
> > >> limited, and we should avoid overwhelming Jenkins even more.
> > >>
> > >>
> > >> -Matthias
> > >>
> > >>
> > >> On 4/27/23 11:45 AM, David Arthur wrote:
> > >> > Hey folks,
> > >> >
> > >> > I stumbled across this wiki page from the infra team that describes
> > the
> > >> > various features supported in the ".asf.yaml" file:
> > >> >
> > >>
> >
> https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features
> > >> >
> > >> > One section that looked particularly interesting was
> > >> >
> > >>
> >
> https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-AssigningexternalcollaboratorswiththetriageroleonGitHub
> > >> >
> > >> > github:
> > >> >    collaborators:
> > >> >      - userA
> > >> >      - userB
> > >> >
> > >> > This would allow us to define non-committers as collaborators on the
> > >> Github
> > >> > project. Concretely, this means they would receive the "triage"
> Github
> > >> role
> > >> > (defined here
> > >> >
> > >>
> >
> https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#permissions-for-each-role
> > >> ).
> > >> > Practically, this means we could let non-committers do things like
> > assign
> > >> > labels and reviewers on Pull Requests.
> > >> >
> > >> > I wanted to see what the committer group thought about this
> feature. I
> > >> > think it could be useful.
> > >> >
> > >> > Cheers,
> > >> > David
> > >> >
> > >>
> >
>


-- 
-David

Reply via email to