Hey folks, Are there any additional steps required in order to be able to trigger Jenkins builds on pull requests? The seemingly relevant link in the asf.yaml file appears to be a dead one - https://github.com/apache/kafka/blob/5b3b385881d5518ef1b2c63cb55244cf80a80da2/.asf.yaml#L25 (else it's a permissions issue).
Thanks, Yash On Wed, May 24, 2023 at 3:35 PM Divij Vaidya <divijvaidy...@gmail.com> wrote: > Hey folks > > A week into this experiment, I am finding the ability to add labels, > request for reviewers and ability to close PRs very useful. > > 1. May I suggest an improvement to the process by requesting for some > guidance on the interest areas for various committers. This would help us > request for reviews from the right set of individuals. > As a reference, we have tried something similar with Apache TinkerPop (see > TinkerPop Contributors section at the end) [1], where the committers self > identify their preferred area of interest. > > 2. I would also request creation of the following new labels: > tiered-storage, transactions, security, refactor, zk-migration, > first-contribution (so that we can prioritize reviews for first time > contributors as an encouragement), build, metrics > > [1] https://tinkerpop.apache.org/ > > -- > Divij Vaidya > > > > On Mon, May 15, 2023 at 11:07 PM John Roesler <vvcep...@apache.org> wrote: > > > Hello again, all, > > > > Just a quick update: after merging the changes to asf.yaml, I received a > > notification that the list is limited to only 10 people, not 20 as the > > documentation states. > > > > Here is the list of folks who will now be able to triage PRs and trigger > > builds: Victoria Xia, Greg Harris, Divij Vaidya, Lucas Brutschy, Yash > > Mayya, Philip Nee, vamossagar12, Christo Lolov, Federico Valeri, and > andymg3 > > > > Thanks all, > > -John > > > > On 2023/05/12 15:53:40 John Roesler wrote: > > > Thanks again for bringing this up, David! > > > > > > As an update to the community, the PMC has approved a process to make > > use of this feature. > > > > > > Here are the relevant updates: > > > > > > PR to add the policy: https://github.com/apache/kafka-site/pull/510 > > > > > > PR to update the list: https://github.com/apache/kafka/pull/13713 > > > > > > Ticket to automate this process.. Contributions welcome :) > > https://issues.apache.org/jira/browse/KAFKA-14995 > > > > > > And to make sure it doesn't fall through the cracks in the mean time, > > here's the release process step: > > > https://cwiki.apache.org/confluence/display/KAFKA/Release+Process#ReleaseProcess-UpdatetheCollaboratorsList > > > > > > Unfortunately, the "collaborator" feature only allows 20 usernames, so > > we have decided to simply take the top 20 non-committer authors from the > > past year (according to git shortlog). Congratulations to our new > > collaborators! > > > > > > Victoria Xia, Greg Harris, Divij Vaidya, Lucas Brutschy, Yash Mayya, > > Philip Nee, vamossagar12, Christo Lolov, Federico Valeri, and andymg3 > > > > > > Thanks, > > > -John > > > > > > On 2023/04/27 18:45:09 David Arthur wrote: > > > > Hey folks, > > > > > > > > I stumbled across this wiki page from the infra team that describes > the > > > > various features supported in the ".asf.yaml" file: > > > > > > > https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features > > > > > > > > One section that looked particularly interesting was > > > > > > > https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-AssigningexternalcollaboratorswiththetriageroleonGitHub > > > > > > > > github: > > > > collaborators: > > > > - userA > > > > - userB > > > > > > > > This would allow us to define non-committers as collaborators on the > > Github > > > > project. Concretely, this means they would receive the "triage" > Github > > role > > > > (defined here > > > > > > > https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#permissions-for-each-role > > ). > > > > Practically, this means we could let non-committers do things like > > assign > > > > labels and reviewers on Pull Requests. > > > > > > > > I wanted to see what the committer group thought about this feature. > I > > > > think it could be useful. > > > > > > > > Cheers, > > > > David > > > > > > > > > >
