chia7712 commented on code in PR #849:
URL: https://github.com/apache/kafka-site/pull/849#discussion_r3104740240
##########
.github/workflows/build-and-deploy.yml:
##########
@@ -51,7 +51,7 @@ jobs:
GITHUB_CONTEXT: ${{ toJson(github) }}
- name: Configure
id: configure
- run: echo "ref=${{ inputs.deploy-to-asf-site && 'asf-site' ||
'asf-staging' }}" >> "$GITHUB_OUTPUT"
+ run: echo "ref=${{ (github.event_name == 'push' ||
inputs.deploy-to-asf-site) && 'asf-site' || 'asf-staging' }}" >>
"$GITHUB_OUTPUT"
Review Comment:
I'm not sure if this is safe for us, as it could expose errors directly to
our readers. Also, it essentially renders `asf-staging` useless, meaning we
won't have the chance to preview or debug the website there beforehand
ping @mimaison WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
