mjsax commented on code in PR #849:
URL: https://github.com/apache/kafka-site/pull/849#discussion_r3143799942
##########
.github/workflows/build-and-deploy.yml:
##########
@@ -51,7 +51,7 @@ jobs:
GITHUB_CONTEXT: ${{ toJson(github) }}
- name: Configure
id: configure
- run: echo "ref=${{ inputs.deploy-to-asf-site && 'asf-site' ||
'asf-staging' }}" >> "$GITHUB_OUTPUT"
+ run: echo "ref=${{ (github.event_name == 'push' ||
inputs.deploy-to-asf-site) && 'asf-site' || 'asf-staging' }}" >>
"$GITHUB_OUTPUT"
Review Comment:
I think the goal of targeting staging is to allow us to review the changes
"live". If we could have a way to deploy the web-page on a PR, we would still
have the safeguard in place? Not sure if this would be (easily) possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
