chia7712 commented on code in PR #849:
URL: https://github.com/apache/kafka-site/pull/849#discussion_r3143982126
##########
.github/workflows/build-and-deploy.yml:
##########
@@ -51,7 +51,7 @@ jobs:
GITHUB_CONTEXT: ${{ toJson(github) }}
- name: Configure
id: configure
- run: echo "ref=${{ inputs.deploy-to-asf-site && 'asf-site' ||
'asf-staging' }}" >> "$GITHUB_OUTPUT"
+ run: echo "ref=${{ (github.event_name == 'push' ||
inputs.deploy-to-asf-site) && 'asf-site' || 'asf-staging' }}" >>
"$GITHUB_OUTPUT"
Review Comment:
> Not sure if this would be (easily) possible.
Another simple approach is a post-commit check. After deploying to the
staging site, the CI can leave a comment on the PR to remind the author to
double-check the results. We can even include a note like: 'This will go live
in 24 hours (or on the next schedule). Please file a follow-up PR if you spot
any issues on staging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
