[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151423#comment-14151423 ]
Anton Karamanov commented on KAFKA-1644: ---------------------------------------- Does this prevent it from being inherited from {{RequestOrResponse}}? From what I see there's no real impact on server-side code and it would be really useful on a client-side. Especially now that [API is completely public (KAFKA-1640)|KAFKA-1640]). My only concern is that {{RequestOrResponse}} trait requires to implement {{writeTo}} method, which wouldn't work for {{FetchResponse}} the same way it does for other {{RequestOrResponse}}s. In the patch I've provided it only serves to write a header of a fetch response. > Inherit FetchResponse from RequestOrResponse > -------------------------------------------- > > Key: KAFKA-1644 > URL: https://issues.apache.org/jira/browse/KAFKA-1644 > Project: Kafka > Issue Type: Bug > Reporter: Anton Karamanov > Assignee: Anton Karamanov > Attachments: > 0001-KAFKA-1644-Inherit-FetchResponse-from-RequestOrRespo.patch > > > Unlike all other Kafka API responses {{FetchResponse}} is not a subclass of > RequestOrResponse, which requires handling it as a special case while > processing responses. -- This message was sent by Atlassian JIRA (v6.3.4#6332)