[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155678#comment-14155678
]
Guozhang Wang commented on KAFKA-1644:
--------------------------------------
Anton, I think Jun's not saying that there is a blocker for doing so, it's just
that since FetchResponse does not use writeTo to write to the socket, but use
FetchReponseSend instead for zero-copy, it may not logically be treated as
inheritance of RequestOrResponse. After looking into your patch I see you are
enforcing this by letting FetchResponseSend to just call FetchResponse.writeTo
instead, which I think is OK if we do have a strong reason for letting
FetchResponse inheriting from RequestOrResponse.
> Inherit FetchResponse from RequestOrResponse
> --------------------------------------------
>
> Key: KAFKA-1644
> URL: https://issues.apache.org/jira/browse/KAFKA-1644
> Project: Kafka
> Issue Type: Bug
> Reporter: Anton Karamanov
> Assignee: Anton Karamanov
> Attachments:
> 0001-KAFKA-1644-Inherit-FetchResponse-from-RequestOrRespo.patch
>
>
> Unlike all other Kafka API responses {{FetchResponse}} is not a subclass of
> RequestOrResponse, which requires handling it as a special case while
> processing responses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
